CVE-2024-1631 agent-js: Insecure Key Generation in `Ed25519KeyIdentity.generate`

2024-02-2102:12:38

CWE-330

CWE-321

Dfinity

www.cve.org

ed25519

key generation

insecure

compromised

seed value

library

funds

principal

CVSS3

9.1

Attack Vector

NETWORK

Attack Complexity

LOW

Privileges Required

NONE

User Interaction

NONE

Scope

UNCHANGED

Confidentiality Impact

HIGH

Integrity Impact

HIGH

Availability Impact

NONE

CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:N

AI Score

9.4

Confidence

High

EPSS

Percentile

15.5%

JSON

Impact: The library offers a function to generate an ed25519 key pair via Ed25519KeyIdentity.generate with an optional param to provide a 32 byte seed value, which will then be used as the secret key. When no seed value is provided, it is expected that the library generates the secret key using secure randomness. However, a recent change broke this guarantee and uses an insecure seed for key pair generation. Since the private key of this identity (535yc-uxytb-gfk7h-tny7p-vjkoe-i4krp-3qmcl-uqfgr-cpgej-yqtjq-rqe) is compromised, one could lose funds associated with the principal on ledgers or lose access to a canister where this principal is the controller.

CNA Affected

[
  {
    "defaultStatus": "unaffected",
    "product": "agent-js",
    "programFiles": [
      "https://github.com/dfinity/agent-js/blob/main/packages/identity/src/identity/ed25519.ts"
    ],
    "vendor": "Internet Computer",
    "versions": [
      {
        "lessThan": "v1.0.1",
        "status": "affected",
        "version": "v0.20.0-beta.0",
        "versionType": "1.0.1"
      }
    ]
  }
]