CVE-2024-26885 bpf: Fix DEVMAP_HASH overflow check on 32-bit arches

2024-04-1710:27:40

Linux

www.cve.org

linux kernel

vulnerability

bpf

devmap_hash

32-bit arches

overflow check

unsigned long

arm32

AI Score

7.9

Confidence

High

EPSS

Percentile

5.1%

JSON

In the Linux kernel, the following vulnerability has been resolved:

bpf: Fix DEVMAP_HASH overflow check on 32-bit arches

The devmap code allocates a number hash buckets equal to the next power
of two of the max_entries value provided when creating the map. When
rounding up to the next power of two, the 32-bit variable storing the
number of buckets can overflow, and the code checks for overflow by
checking if the truncated 32-bit value is equal to 0. However, on 32-bit
arches the rounding up itself can overflow mid-way through, because it
ends up doing a left-shift of 32 bits on an unsigned long value. If the
size of an unsigned long is four bytes, this is undefined behaviour, so
there is no guarantee that we’ll end up with a nice and tidy 0-value at
the end.

Syzbot managed to turn this into a crash on arm32 by creating a
DEVMAP_HASH with max_entries > 0x80000000 and then trying to update it.
Fix this by moving the overflow check to before the rounding up
operation.

CNA Affected

[
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "unaffected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "kernel/bpf/devmap.c"
    ],
    "versions": [
      {
        "version": "6f9d451ab1a3",
        "lessThan": "225da02acdc9",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "6f9d451ab1a3",
        "lessThan": "c826502bed93",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "6f9d451ab1a3",
        "lessThan": "edf7990baa48",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "6f9d451ab1a3",
        "lessThan": "250051acc21f",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "6f9d451ab1a3",
        "lessThan": "22079b3a4233",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "6f9d451ab1a3",
        "lessThan": "e89386f62ce9",
        "status": "affected",
        "versionType": "git"
      },
      {
        "version": "6f9d451ab1a3",
        "lessThan": "281d464a34f5",
        "status": "affected",
        "versionType": "git"
      }
    ]
  },
  {
    "product": "Linux",
    "vendor": "Linux",
    "defaultStatus": "affected",
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "programFiles": [
      "kernel/bpf/devmap.c"
    ],
    "versions": [
      {
        "version": "5.4",
        "status": "affected"
      },
      {
        "version": "0",
        "lessThan": "5.4",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.10.214",
        "lessThanOrEqual": "5.10.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "5.15.153",
        "lessThanOrEqual": "5.15.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.1.83",
        "lessThanOrEqual": "6.1.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.6.23",
        "lessThanOrEqual": "6.6.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.7.11",
        "lessThanOrEqual": "6.7.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.8.2",
        "lessThanOrEqual": "6.8.*",
        "status": "unaffected",
        "versionType": "custom"
      },
      {
        "version": "6.9",
        "lessThanOrEqual": "*",
        "status": "unaffected",
        "versionType": "original_commit_for_fix"
      }
    ]
  }
]