kiwitcms vulnerable to stored cross-site scripting via unrestricted file upload

Impact

Kiwi TCMS allows users to upload attachments to test plans, test cases, etc. Earlier versions of Kiwi TCMS had introduced upload validators in order to prevent potentially dangerous files from being uploaded and Content-Security-Policy definition to prevent cross-site-scripting attacks.

The upload validation checks were not 100% robust which left the possibility to circumvent them and upload a potentially dangerous file which allows execution of arbitrary JavaScript in the browser. Additionally we’ve discovered that Nginx’s proxy_pass directive will strip some headers negating protections built into Kiwi TCMS when served behind a reverse proxy.

Patches

• Improved file upload validation code
• Updated Nginx reverse proxy configuration for *.tenant.kiwitcms.org

Workarounds

If serving Kiwi TCMS behind a reverse proxy make sure that additional header values are still passed to the client browser. If they aren’t redefine them inside the proxy configuration. See etc/nginx.conf#L66-L68 and etc/nginx.conf#L87

References

Disclosed by M Nadeem Qazi.