When using the #apply
method from image_processing to apply a series of operations that are coming from unsanitized user input, this allows the attacker to execute shell commands:
ImageProcessing::Vips.apply({ system: "echo EXECUTED" })
#>> EXECUTED
This method is called internally by Active Storage variants, so Active Storage is vulnerable as well.
The vulnerability has been fixed in version 1.12.2 of image_processing.
If you’re processing based on user input, it’s highly recommended that you always sanitize the user input, by allowing only a constrained set of operations. For example:
operations = params[:operations]
.map { |operation| [operation[:name], *operation[:value]] }
.select { |name, *| name.to_s.include? %w[resize_to_limit strip ...] } # sanitization
ImageProcessing::Vips.apply(operations)
github.com/janko/image_processing
github.com/janko/image_processing/commit/038e4574e8f4f4b636a62394e09983c71980dada
github.com/janko/image_processing/security/advisories/GHSA-cxf7-qrc5-9446
github.com/rubysec/ruby-advisory-db/blob/master/gems/image_processing/CVE-2022-24720.yml
nvd.nist.gov/vuln/detail/CVE-2022-24720
www.debian.org/security/2022/dsa-5310