Lucene search

K
rustsecRustsecRUSTSEC-2021-0083
HistoryJan 20, 2021 - 12:00 p.m.

QueryInterface should call AddRef before returning pointer

2021-01-2012:00:00
rustsec.org
9

0.001 Low

EPSS

Percentile

39.2%

Affected version of this crate, which is a required dependency in com-impl,
provides a faulty implementation of the IUnknown::QueryInterface method.

QueryInterface implementation must call IUnknown::AddRef before returning the pointer,
as describe in this documentation:
<https://docs.microsoft.com/en-us/windows/win32/api/unknwn/nf-unknwn-iunknown-queryinterface(refiid_void)&gt;

As it is not incrementing the refcount as expected, the following calls to IUnknown::Release method
will cause WMI to drop reference to the interface, and can lead to invalid reference.

This is documented in <https://docs.microsoft.com/en-us/windows/win32/learnwin32/managing-the-lifetime-of-an-object#reference-counting&gt;

There is no simple workaround, as you can’t know how many time QueryInterface will be called.
The only way to quick fix this is to use the macro expanded version of the code and modify
the QueryInterface method to add the AddRef call yourself.

The issue was corrected in commit 9803f31fbd1717d482d848f041044d061fca6da7.

CPENameOperatorVersion
derive-com-impllt0.1.2

0.001 Low

EPSS

Percentile

39.2%

Related for RUSTSEC-2021-0083