CVE-2023-52443 apparmor: avoid crash when parsed profile name is empty

2024-02-2216:13:31

Linux

github.com

apparmor

profile crash

unpack_profile

aa_splitn_fqname

denial of service

linux kernel

AI Score

6.5

Confidence

Low

SSVC

Exploitation

none

Automatable

Technical Impact

partial

JSON

In the Linux kernel, the following vulnerability has been resolved:

apparmor: avoid crash when parsed profile name is empty

When processing a packed profile in unpack_profile() described like

“profile :ns::samba-dcerpcd /usr/lib*/samba/{,samba/}samba-dcerpcd {…}”

a string “:samba-dcerpcd” is unpacked as a fully-qualified name and then
passed to aa_splitn_fqname().

aa_splitn_fqname() treats “:samba-dcerpcd” as only containing a namespace.
Thus it returns NULL for tmpname, meanwhile tmpns is non-NULL. Later
aa_alloc_profile() crashes as the new profile name is NULL now.

general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
CPU: 6 PID: 1657 Comm: apparmor_parser Not tainted 6.7.0-rc2-dirty #16
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-3-gd478f380-rebuilt.opensuse.org 04/01/2014
RIP: 0010:strlen+0x1e/0xa0
Call Trace:
<TASK>
? strlen+0x1e/0xa0
aa_policy_init+0x1bb/0x230
aa_alloc_profile+0xb1/0x480
unpack_profile+0x3bc/0x4960
aa_unpack+0x309/0x15e0
aa_replace_profiles+0x213/0x33c0
policy_update+0x261/0x370
profile_replace+0x20e/0x2a0
vfs_write+0x2af/0xe00
ksys_write+0x126/0x250
do_syscall_64+0x46/0xf0
entry_SYSCALL_64_after_hwframe+0x6e/0x76
</TASK>
—[ end trace 0000000000000000 ]—
RIP: 0010:strlen+0x1e/0xa0

It seems such behaviour of aa_splitn_fqname() is expected and checked in
other places where it is called (e.g. aa_remove_profiles). Well, there
is an explicit comment “a ns name without a following profile is allowed”
inside.

AFAICS, nothing can prevent unpacked “name” to be in form like
“:samba-dcerpcd” - it is passed from userspace.

Deny the whole profile set replacement in such case and inform user with
EPROTO and an explaining message.

Found by Linux Verification Center (linuxtesting.org).

CNA Affected

[
  {
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "vendor": "Linux",
    "product": "Linux",
    "versions": [
      {
        "status": "affected",
        "version": "04dc715e24d0",
        "lessThan": "9286ee97aa48",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "04dc715e24d0",
        "lessThan": "1d8e62b5569c",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "04dc715e24d0",
        "lessThan": "5ff00408e502",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "04dc715e24d0",
        "lessThan": "0a12db736edb",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "04dc715e24d0",
        "lessThan": "9d4fa5fe2b1d",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "04dc715e24d0",
        "lessThan": "5c0392fdafb0",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "04dc715e24d0",
        "lessThan": "77ab09b92f16",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "04dc715e24d0",
        "lessThan": "55a8210c9e7d",
        "versionType": "git"
      }
    ],
    "programFiles": [
      "security/apparmor/policy_unpack.c"
    ],
    "defaultStatus": "unaffected"
  },
  {
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "vendor": "Linux",
    "product": "Linux",
    "versions": [
      {
        "status": "affected",
        "version": "4.11"
      },
      {
        "status": "unaffected",
        "version": "0",
        "lessThan": "4.11",
        "versionType": "custom"
      },
      {
        "status": "unaffected",
        "version": "4.19.306",
        "versionType": "custom",
        "lessThanOrEqual": "4.19.*"
      },
      {
        "status": "unaffected",
        "version": "5.4.268",
        "versionType": "custom",
        "lessThanOrEqual": "5.4.*"
      },
      {
        "status": "unaffected",
        "version": "5.10.209",
        "versionType": "custom",
        "lessThanOrEqual": "5.10.*"
      },
      {
        "status": "unaffected",
        "version": "5.15.148",
        "versionType": "custom",
        "lessThanOrEqual": "5.15.*"
      },
      {
        "status": "unaffected",
        "version": "6.1.75",
        "versionType": "custom",
        "lessThanOrEqual": "6.1.*"
      },
      {
        "status": "unaffected",
        "version": "6.6.14",
        "versionType": "custom",
        "lessThanOrEqual": "6.6.*"
      },
      {
        "status": "unaffected",
        "version": "6.7.2",
        "versionType": "custom",
        "lessThanOrEqual": "6.7.*"
      },
      {
        "status": "unaffected",
        "version": "6.8",
        "versionType": "original_commit_for_fix",
        "lessThanOrEqual": "*"
      }
    ],
    "programFiles": [
      "security/apparmor/policy_unpack.c"
    ],
    "defaultStatus": "affected"
  }
]