CVE-2024-35960 net/mlx5: Properly link new fs rules into the tree

2024-05-2009:41:51

Linux

github.com

linux kernel

vulnerability

resolution

net/mlx5

rule linking

flow handle

crash

patch

fte

7.3 High

AI Score

Confidence

Low

JSON

In the Linux kernel, the following vulnerability has been resolved:

net/mlx5: Properly link new fs rules into the tree

Previously, add_rule_fg would only add newly created rules from the
handle into the tree when they had a refcount of 1. On the other hand,
create_flow_handle tries hard to find and reference already existing
identical rules instead of creating new ones.

These two behaviors can result in a situation where create_flow_handle

creates a new rule and references it, then
in a subsequent step during the same handle creation references it
again,
resulting in a rule with a refcount of 2 that is not linked into the
tree, will have a NULL parent and root and will result in a crash when
the flow group is deleted because del_sw_hw_rule, invoked on rule
deletion, assumes node->parent is != NULL.

This happened in the wild, due to another bug related to incorrect
handling of duplicate pkt_reformat ids, which lead to the code in
create_flow_handle incorrectly referencing a just-added rule in the same
flow handle, resulting in the problem described above. Full details are
at [1].

This patch changes add_rule_fg to add new rules without parents into
the tree, properly initializing them and avoiding the crash. This makes
it more consistent with how rules are added to an FTE in
create_flow_handle.

CNA Affected

[
  {
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "vendor": "Linux",
    "product": "Linux",
    "versions": [
      {
        "status": "affected",
        "version": "74491de93712",
        "lessThan": "de0139719cdd",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "74491de93712",
        "lessThan": "1263b0b26077",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "74491de93712",
        "lessThan": "3d90ca9145f6",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "74491de93712",
        "lessThan": "7aaee12b804c",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "74491de93712",
        "lessThan": "2e8dc5cffc84",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "74491de93712",
        "lessThan": "5cf5337ef701",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "74491de93712",
        "lessThan": "adf67a03af39",
        "versionType": "git"
      },
      {
        "status": "affected",
        "version": "74491de93712",
        "lessThan": "7c6782ad4911",
        "versionType": "git"
      }
    ],
    "programFiles": [
      "drivers/net/ethernet/mellanox/mlx5/core/fs_core.c"
    ],
    "defaultStatus": "unaffected"
  },
  {
    "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
    "vendor": "Linux",
    "product": "Linux",
    "versions": [
      {
        "status": "affected",
        "version": "4.10"
      },
      {
        "status": "unaffected",
        "version": "0",
        "lessThan": "4.10",
        "versionType": "custom"
      },
      {
        "status": "unaffected",
        "version": "4.19.313",
        "versionType": "custom",
        "lessThanOrEqual": "4.19.*"
      },
      {
        "status": "unaffected",
        "version": "5.4.275",
        "versionType": "custom",
        "lessThanOrEqual": "5.4.*"
      },
      {
        "status": "unaffected",
        "version": "5.10.216",
        "versionType": "custom",
        "lessThanOrEqual": "5.10.*"
      },
      {
        "status": "unaffected",
        "version": "5.15.156",
        "versionType": "custom",
        "lessThanOrEqual": "5.15.*"
      },
      {
        "status": "unaffected",
        "version": "6.1.87",
        "versionType": "custom",
        "lessThanOrEqual": "6.1.*"
      },
      {
        "status": "unaffected",
        "version": "6.6.28",
        "versionType": "custom",
        "lessThanOrEqual": "6.6.*"
      },
      {
        "status": "unaffected",
        "version": "6.8.7",
        "versionType": "custom",
        "lessThanOrEqual": "6.8.*"
      },
      {
        "status": "unaffected",
        "version": "6.9",
        "versionType": "original_commit_for_fix",
        "lessThanOrEqual": "*"
      }
    ],
    "programFiles": [
      "drivers/net/ethernet/mellanox/mlx5/core/fs_core.c"
    ],
    "defaultStatus": "affected"
  }
]